silverwind
371a06403a
Net **-650 LOC** by removing duplication and dead noise. All tests pass.
### Duplication & helpers
- Extracted shared slim helpers (`UserLogin`, `UserLogins`, `LabelNames`, `BodyWithAttachments`, `UserDetail`, `Repo`/`Repos`, `Label`/`Labels`) into `pkg/slim`. Deleted the 4 copies that lived in `issue/`, `pull/`, `search/`, `repo/` (plus duplicate `slimUserDetail`/`slimRepo`/`slimLabels` across packages).
- Added `params.GetOptionalBoolPtr` and `params.GetOptionalStringPtr`. Replaced 18 awkward `new(localVar); if !ok { = nil }` patterns across `repo/`, `pull/`, `issue/`, `label/`, `milestone/`, `search/`.
- Extracted `pullRequestReviewerFn` for the 99%-identical `createPullRequestReviewerFn`/`deletePullRequestReviewerFn` pair.
### Dead code & noise
- Deleted **122** `log.Debugf("Called X")` narration lines (`zap.AddCaller` already records the caller) and pruned 19 unused `log` imports.
- Removed the unused `log.Logger` wrapper; the mcp-go server now uses `log.Default().Sugar()` directly (matches `util.Logger`).
- Deleted dead `s.DeleteTools("")` — confirmed no-op in mcp-go.
- Stripped WHAT-narration comments per project guidance.
### Correctness & consistency
- Fixed `log.Errorf(err.Error())` format-string bug in `pkg/to/to.go` — a `%` in the error would have been interpreted as a directive.
- Standardized `to.TextResult`/`to.ErrorResult` usage; `release.go`, `tag.go`, `branch.go` were bypassing the helpers in 9 sites (skipping the wrapper's debug/error logging).
- Made `params.GetString` reject empty strings; dropped 21 redundant `err != nil || x == ""` checks in `operation/actions/`.
- Replaced raw `args["org"].(string)` in `ListOrgReposFn` with `params.GetString` to match the rest of the codebase.
### Performance
- **Cached `*gitea.Client` by host+token via `sync.Map`** + shared `*http.Transport` via `sync.Once` for both SDK and raw REST paths. Eliminates the SDK's `/api/v1/version` preflight on every tool call and enables connection keep-alive across requests.
- Gated `to.TextResult` debug log behind `flag.Debug` to skip the `string(bytes)` allocation when debug is off.
- Hoisted `8192` and `60s` magic numbers in `pkg/gitea/rest.go` into named constants.
---
This PR was written with the help of Claude Opus 4.7
---------
Co-authored-by: silverwind <silv3rwind@gmail.com>
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/195
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
70 lines
1.6 KiB
Go
70 lines
1.6 KiB
Go
package issue
|
|
|
|
import (
|
|
"testing"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
)
|
|
|
|
func TestSlimIssue(t *testing.T) {
|
|
i := &gitea_sdk.Issue{
|
|
Index: 42,
|
|
Title: "Bug report",
|
|
Body: "Something is broken",
|
|
State: "open",
|
|
HTMLURL: "https://gitea.com/org/repo/issues/42",
|
|
Poster: &gitea_sdk.User{UserName: "alice"},
|
|
Labels: []*gitea_sdk.Label{{Name: "bug"}},
|
|
Milestone: &gitea_sdk.Milestone{
|
|
ID: 1,
|
|
Title: "v1.0",
|
|
},
|
|
PullRequest: &gitea_sdk.PullRequestMeta{HasMerged: false},
|
|
}
|
|
|
|
m := slimIssue(i)
|
|
|
|
if m["number"] != int64(42) {
|
|
t.Errorf("expected number 42, got %v", m["number"])
|
|
}
|
|
if m["body"] != "Something is broken" {
|
|
t.Errorf("expected body, got %v", m["body"])
|
|
}
|
|
if m["is_pull"] != true {
|
|
t.Error("expected is_pull true for issue with PullRequest")
|
|
}
|
|
|
|
ms := m["milestone"].(map[string]any)
|
|
if ms["title"] != "v1.0" {
|
|
t.Errorf("expected milestone title v1.0, got %v", ms["title"])
|
|
}
|
|
}
|
|
|
|
func TestSlimIssues_ListIsSlimmer(t *testing.T) {
|
|
i := &gitea_sdk.Issue{
|
|
Index: 1,
|
|
Title: "Issue",
|
|
State: "open",
|
|
Body: "Full body",
|
|
Poster: &gitea_sdk.User{UserName: "alice"},
|
|
Labels: []*gitea_sdk.Label{{Name: "enhancement"}},
|
|
}
|
|
|
|
single := slimIssue(i)
|
|
list := slimIssues([]*gitea_sdk.Issue{i})
|
|
|
|
// Single has body, list does not
|
|
if _, ok := single["body"]; !ok {
|
|
t.Error("single issue should have body")
|
|
}
|
|
if _, ok := list[0]["body"]; ok {
|
|
t.Error("list issue should not have body")
|
|
}
|
|
}
|
|
|
|
func TestSlimIssues_Nil(t *testing.T) {
|
|
if r := slimIssues(nil); len(r) != 0 {
|
|
t.Errorf("expected empty slice, got %v", r)
|
|
}
|
|
}
|