371a06403a
Net **-650 LOC** by removing duplication and dead noise. All tests pass.
### Duplication & helpers
- Extracted shared slim helpers (`UserLogin`, `UserLogins`, `LabelNames`, `BodyWithAttachments`, `UserDetail`, `Repo`/`Repos`, `Label`/`Labels`) into `pkg/slim`. Deleted the 4 copies that lived in `issue/`, `pull/`, `search/`, `repo/` (plus duplicate `slimUserDetail`/`slimRepo`/`slimLabels` across packages).
- Added `params.GetOptionalBoolPtr` and `params.GetOptionalStringPtr`. Replaced 18 awkward `new(localVar); if !ok { = nil }` patterns across `repo/`, `pull/`, `issue/`, `label/`, `milestone/`, `search/`.
- Extracted `pullRequestReviewerFn` for the 99%-identical `createPullRequestReviewerFn`/`deletePullRequestReviewerFn` pair.
### Dead code & noise
- Deleted **122** `log.Debugf("Called X")` narration lines (`zap.AddCaller` already records the caller) and pruned 19 unused `log` imports.
- Removed the unused `log.Logger` wrapper; the mcp-go server now uses `log.Default().Sugar()` directly (matches `util.Logger`).
- Deleted dead `s.DeleteTools("")` — confirmed no-op in mcp-go.
- Stripped WHAT-narration comments per project guidance.
### Correctness & consistency
- Fixed `log.Errorf(err.Error())` format-string bug in `pkg/to/to.go` — a `%` in the error would have been interpreted as a directive.
- Standardized `to.TextResult`/`to.ErrorResult` usage; `release.go`, `tag.go`, `branch.go` were bypassing the helpers in 9 sites (skipping the wrapper's debug/error logging).
- Made `params.GetString` reject empty strings; dropped 21 redundant `err != nil || x == ""` checks in `operation/actions/`.
- Replaced raw `args["org"].(string)` in `ListOrgReposFn` with `params.GetString` to match the rest of the codebase.
### Performance
- **Cached `*gitea.Client` by host+token via `sync.Map`** + shared `*http.Transport` via `sync.Once` for both SDK and raw REST paths. Eliminates the SDK's `/api/v1/version` preflight on every tool call and enables connection keep-alive across requests.
- Gated `to.TextResult` debug log behind `flag.Debug` to skip the `string(bytes)` allocation when debug is off.
- Hoisted `8192` and `60s` magic numbers in `pkg/gitea/rest.go` into named constants.
---
This PR was written with the help of Claude Opus 4.7
---------
Co-authored-by: silverwind <silv3rwind@gmail.com>
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/195
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
211 lines
6.5 KiB
Go
211 lines
6.5 KiB
Go
package repo
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
|
|
"gitea.com/gitea/gitea-mcp/pkg/annotation"
|
|
"gitea.com/gitea/gitea-mcp/pkg/gitea"
|
|
"gitea.com/gitea/gitea-mcp/pkg/params"
|
|
"gitea.com/gitea/gitea-mcp/pkg/slim"
|
|
"gitea.com/gitea/gitea-mcp/pkg/to"
|
|
"gitea.com/gitea/gitea-mcp/pkg/tool"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
"github.com/mark3labs/mcp-go/mcp"
|
|
"github.com/mark3labs/mcp-go/server"
|
|
)
|
|
|
|
var Tool = tool.New()
|
|
|
|
const (
|
|
CreateRepoToolName = "create_repo"
|
|
ForkRepoToolName = "fork_repo"
|
|
ListMyReposToolName = "list_my_repos"
|
|
ListOrgReposToolName = "list_org_repos"
|
|
)
|
|
|
|
var (
|
|
CreateRepoTool = mcp.NewTool(
|
|
CreateRepoToolName,
|
|
mcp.WithToolAnnotation(annotation.Write("Create a new repository")),
|
|
mcp.WithString("name", mcp.Required()),
|
|
mcp.WithString("description"),
|
|
mcp.WithBoolean("private"),
|
|
mcp.WithString("issue_labels"),
|
|
mcp.WithBoolean("auto_init"),
|
|
mcp.WithBoolean("template"),
|
|
mcp.WithString("gitignores"),
|
|
mcp.WithString("license"),
|
|
mcp.WithString("readme"),
|
|
mcp.WithString("default_branch"),
|
|
mcp.WithString("trust_model", mcp.Enum("default", "collaborator", "committer", "collaboratorcommitter")),
|
|
mcp.WithString("object_format_name", mcp.Enum("sha1", "sha256")),
|
|
mcp.WithString("organization", mcp.Description("defaults to personal account")),
|
|
)
|
|
|
|
ForkRepoTool = mcp.NewTool(
|
|
ForkRepoToolName,
|
|
mcp.WithToolAnnotation(annotation.Write("Fork a repository")),
|
|
mcp.WithString("user", mcp.Required(), mcp.Description("owner of source repo")),
|
|
mcp.WithString("repo", mcp.Required()),
|
|
mcp.WithString("organization", mcp.Description("target org")),
|
|
mcp.WithString("name", mcp.Description("fork name")),
|
|
)
|
|
|
|
ListMyReposTool = mcp.NewTool(
|
|
ListMyReposToolName,
|
|
mcp.WithToolAnnotation(annotation.ReadOnly("List my repositories")),
|
|
mcp.WithNumber("page", mcp.Description(params.PageDesc), mcp.DefaultNumber(1), mcp.Min(1)),
|
|
mcp.WithNumber("per_page", mcp.Description(params.PaginationDesc), mcp.DefaultNumber(30), mcp.Min(1)),
|
|
)
|
|
|
|
ListOrgReposTool = mcp.NewTool(
|
|
ListOrgReposToolName,
|
|
mcp.WithToolAnnotation(annotation.ReadOnly("List organization repositories")),
|
|
mcp.WithString("org", mcp.Required()),
|
|
mcp.WithNumber("page", mcp.Description(params.PageDesc), mcp.DefaultNumber(1), mcp.Min(1)),
|
|
mcp.WithNumber("per_page", mcp.Description(params.PaginationDesc), mcp.DefaultNumber(100), mcp.Min(1)),
|
|
)
|
|
)
|
|
|
|
func init() {
|
|
Tool.RegisterWrite(server.ServerTool{
|
|
Tool: CreateRepoTool,
|
|
Handler: CreateRepoFn,
|
|
})
|
|
Tool.RegisterWrite(server.ServerTool{
|
|
Tool: ForkRepoTool,
|
|
Handler: ForkRepoFn,
|
|
})
|
|
Tool.RegisterRead(server.ServerTool{
|
|
Tool: ListMyReposTool,
|
|
Handler: ListMyReposFn,
|
|
})
|
|
Tool.RegisterRead(server.ServerTool{
|
|
Tool: ListOrgReposTool,
|
|
Handler: ListOrgReposFn,
|
|
})
|
|
}
|
|
|
|
func CreateRepoFn(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
|
|
args := req.GetArguments()
|
|
name, err := params.GetString(args, "name")
|
|
if err != nil {
|
|
return to.ErrorResult(err)
|
|
}
|
|
description, _ := args["description"].(string)
|
|
private, _ := args["private"].(bool)
|
|
issueLabels, _ := args["issue_labels"].(string)
|
|
autoInit, _ := args["auto_init"].(bool)
|
|
template, _ := args["template"].(bool)
|
|
gitignores, _ := args["gitignores"].(string)
|
|
license, _ := args["license"].(string)
|
|
readme, _ := args["readme"].(string)
|
|
defaultBranch, _ := args["default_branch"].(string)
|
|
trustModel, _ := args["trust_model"].(string)
|
|
objectFormatName, _ := args["object_format_name"].(string)
|
|
organization, _ := args["organization"].(string)
|
|
|
|
opt := gitea_sdk.CreateRepoOption{
|
|
Name: name,
|
|
Description: description,
|
|
Private: private,
|
|
IssueLabels: issueLabels,
|
|
AutoInit: autoInit,
|
|
Template: template,
|
|
Gitignores: gitignores,
|
|
License: license,
|
|
Readme: readme,
|
|
DefaultBranch: defaultBranch,
|
|
TrustModel: gitea_sdk.TrustModel(trustModel),
|
|
ObjectFormatName: objectFormatName,
|
|
}
|
|
|
|
var repo *gitea_sdk.Repository
|
|
client, err := gitea.ClientFromContext(ctx)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("get gitea client err: %v", err))
|
|
}
|
|
if organization != "" {
|
|
repo, _, err = client.CreateOrgRepo(organization, opt)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("create organization repository '%s' in '%s' err: %v", name, organization, err))
|
|
}
|
|
} else {
|
|
repo, _, err = client.CreateRepo(opt)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("create repository '%s' err: %v", name, err))
|
|
}
|
|
}
|
|
return to.TextResult(slim.Repo(repo))
|
|
}
|
|
|
|
func ForkRepoFn(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
|
|
args := req.GetArguments()
|
|
user, err := params.GetString(args, "user")
|
|
if err != nil {
|
|
return to.ErrorResult(err)
|
|
}
|
|
repo, err := params.GetString(args, "repo")
|
|
if err != nil {
|
|
return to.ErrorResult(err)
|
|
}
|
|
opt := gitea_sdk.CreateForkOption{
|
|
Organization: params.GetOptionalStringPtr(args, "organization"),
|
|
Name: params.GetOptionalStringPtr(args, "name"),
|
|
}
|
|
client, err := gitea.ClientFromContext(ctx)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("get gitea client err: %v", err))
|
|
}
|
|
_, _, err = client.CreateFork(user, repo, opt)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("fork repository error: %v", err))
|
|
}
|
|
return to.TextResult("Fork success")
|
|
}
|
|
|
|
func ListMyReposFn(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
|
|
page, pageSize := params.GetPagination(req.GetArguments(), 30)
|
|
opt := gitea_sdk.ListReposOptions{
|
|
ListOptions: gitea_sdk.ListOptions{
|
|
Page: page,
|
|
PageSize: pageSize,
|
|
},
|
|
}
|
|
client, err := gitea.ClientFromContext(ctx)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("get gitea client err: %v", err))
|
|
}
|
|
repos, _, err := client.ListMyRepos(opt)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("list my repositories error: %v", err))
|
|
}
|
|
|
|
return to.TextResult(slim.Repos(repos))
|
|
}
|
|
|
|
func ListOrgReposFn(ctx context.Context, req mcp.CallToolRequest) (*mcp.CallToolResult, error) {
|
|
org, err := params.GetString(req.GetArguments(), "org")
|
|
if err != nil {
|
|
return to.ErrorResult(err)
|
|
}
|
|
page, pageSize := params.GetPagination(req.GetArguments(), 100)
|
|
opt := gitea_sdk.ListOrgReposOptions{
|
|
ListOptions: gitea_sdk.ListOptions{
|
|
Page: page,
|
|
PageSize: pageSize,
|
|
},
|
|
}
|
|
client, err := gitea.ClientFromContext(ctx)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("get gitea client err: %v", err))
|
|
}
|
|
repos, _, err := client.ListOrgRepos(org, opt)
|
|
if err != nil {
|
|
return to.ErrorResult(fmt.Errorf("list organization '%s' repositories error: %v", org, err))
|
|
}
|
|
return to.TextResult(repos)
|
|
}
|