2e67d5ebf3
- Tool list size reduced by 26.6% (43,032 → 31,599 bytes on the `tools/list` JSON-RPC response). - Trim redundant tool/param descriptions; shared description constants for `owner`/`repo`/`page`/`per_page`. - Schemas now use github-mcp-server param names directly: `issue_number` (was `index` on issue tools), `pull_number` (was `index` on PR tools), `path` (was `filePath`), `query` (was `keyword` on user/repo search), `per_page` (was `perPage`). - New PR read methods `get_files` and `get_status`; new PR write method `update_branch` (update PR branch from base). - `list_org_repos` now uses `per_page` (was `pageSize`). - `milestone_write` accepts `update` and `edit`. - `create_branch` `old_branch` is optional; Gitea defaults to the repo default branch. - Fix `list_commits` handler to honour optional `page`/`per_page` schema (was erroring out when callers omitted them). --- This PR was written with the help of Claude Opus 4.7 Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/191 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: silverwind <me@silverwind.io> Co-committed-by: silverwind <me@silverwind.io>
140 lines
3.7 KiB
Go
140 lines
3.7 KiB
Go
package params
|
|
|
|
import (
|
|
"fmt"
|
|
"strconv"
|
|
"time"
|
|
)
|
|
|
|
// Shared parameter description strings used across tools. Extracted to avoid
|
|
// repeating the same boilerplate in every tool schema (saves tokens in the
|
|
// tool list sent to MCP clients).
|
|
const (
|
|
OwnerDesc = "repo owner"
|
|
RepoDesc = "repo name"
|
|
PageDesc = "page"
|
|
PaginationDesc = "results per page"
|
|
)
|
|
|
|
// GetString extracts a required string parameter from MCP tool arguments.
|
|
func GetString(args map[string]any, key string) (string, error) {
|
|
val, ok := args[key].(string)
|
|
if !ok {
|
|
return "", fmt.Errorf("%s is required", key)
|
|
}
|
|
return val, nil
|
|
}
|
|
|
|
// GetOptionalString extracts an optional string parameter with a default value.
|
|
func GetOptionalString(args map[string]any, key, defaultVal string) string {
|
|
if val, ok := args[key].(string); ok {
|
|
return val
|
|
}
|
|
return defaultVal
|
|
}
|
|
|
|
// GetStringSlice extracts an optional string slice parameter from MCP tool arguments.
|
|
func GetStringSlice(args map[string]any, key string) []string {
|
|
val, ok := args[key]
|
|
if !ok {
|
|
return nil
|
|
}
|
|
sliceVal, ok := val.([]any)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
out := make([]string, 0, len(sliceVal))
|
|
for _, item := range sliceVal {
|
|
if s, ok := item.(string); ok {
|
|
out = append(out, s)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
|
|
// GetPagination extracts page and per_page parameters, returning them as ints.
|
|
func GetPagination(args map[string]any, defaultPageSize int64) (page, pageSize int) {
|
|
return int(GetOptionalInt(args, "page", 1)), int(GetOptionalInt(args, "per_page", defaultPageSize))
|
|
}
|
|
|
|
// ToInt64 converts a value to int64, accepting both float64 (JSON number) and
|
|
// string representations. Returns false if the value cannot be converted.
|
|
func ToInt64(val any) (int64, bool) {
|
|
switch v := val.(type) {
|
|
case float64:
|
|
return int64(v), true
|
|
case string:
|
|
i, err := strconv.ParseInt(v, 10, 64)
|
|
if err != nil {
|
|
return 0, false
|
|
}
|
|
return i, true
|
|
default:
|
|
return 0, false
|
|
}
|
|
}
|
|
|
|
// GetIndex extracts a required integer parameter from MCP tool arguments.
|
|
// It accepts both numeric (float64 from JSON) and string representations.
|
|
// This provides better UX for LLM callers that may naturally use strings
|
|
// for identifiers like issue/PR numbers.
|
|
func GetIndex(args map[string]any, key string) (int64, error) {
|
|
val, exists := args[key]
|
|
if !exists {
|
|
return 0, fmt.Errorf("%s is required", key)
|
|
}
|
|
|
|
if i, ok := ToInt64(val); ok {
|
|
return i, nil
|
|
}
|
|
|
|
if s, ok := val.(string); ok {
|
|
return 0, fmt.Errorf("%s must be a valid integer (got %q)", key, s)
|
|
}
|
|
|
|
return 0, fmt.Errorf("%s must be a number or numeric string", key)
|
|
}
|
|
|
|
// GetInt64Slice extracts a required int64 slice parameter from MCP tool arguments.
|
|
func GetInt64Slice(args map[string]any, key string) ([]int64, error) {
|
|
raw, ok := args[key].([]any)
|
|
if !ok {
|
|
return nil, fmt.Errorf("%s (array of IDs) is required", key)
|
|
}
|
|
out := make([]int64, 0, len(raw))
|
|
for _, v := range raw {
|
|
id, ok := ToInt64(v)
|
|
if !ok {
|
|
return nil, fmt.Errorf("invalid ID in %s array", key)
|
|
}
|
|
out = append(out, id)
|
|
}
|
|
return out, nil
|
|
}
|
|
|
|
// GetOptionalTime extracts an optional RFC3339 timestamp parameter, returning nil if missing or unparseable.
|
|
func GetOptionalTime(args map[string]any, key string) *time.Time {
|
|
val, ok := args[key].(string)
|
|
if !ok {
|
|
return nil
|
|
}
|
|
if t, err := time.Parse(time.RFC3339, val); err == nil {
|
|
return &t
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// GetOptionalInt extracts an optional integer parameter from MCP tool arguments.
|
|
// Returns defaultVal if the key is missing or the value cannot be parsed.
|
|
// Accepts both float64 (JSON number) and string representations.
|
|
func GetOptionalInt(args map[string]any, key string, defaultVal int64) int64 {
|
|
val, exists := args[key]
|
|
if !exists {
|
|
return defaultVal
|
|
}
|
|
if i, ok := ToInt64(val); ok {
|
|
return i
|
|
}
|
|
return defaultVal
|
|
}
|