silverwind
7759c7f327
The Gitea API returns an `assets` array on issue and comment responses, but the SDK structs drop it — so attachments are invisible to MCP agents.
Append each attachment as a `[name](url)` markdown link at the end of the body, mirroring how GitHub embeds attachments inline (which `github-mcp-server` preserves as-is).
**Coverage:**
- `issue_read get` — issue body attachments
- `issue_read get_comments` — issue and PR conversation comment attachments (same endpoint)
- `pull_request_read get` — PR description attachments (Gitea's `/pulls/` endpoint omits `assets`, so a follow-up best-effort call to `/issues/{n}/assets` surfaces them; PRs are issues internally)
PR review summaries and line-comment reviews don't support attachments per the Gitea API spec, so nothing to do there.
Closes https://gitea.com/gitea/gitea-mcp/issues/182
---
This PR was written with the help of Claude Opus 4.7
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/183
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
93 lines
2.5 KiB
Go
93 lines
2.5 KiB
Go
package issue
|
|
|
|
import (
|
|
"testing"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
)
|
|
|
|
func TestSlimIssue(t *testing.T) {
|
|
i := &gitea_sdk.Issue{
|
|
Index: 42,
|
|
Title: "Bug report",
|
|
Body: "Something is broken",
|
|
State: "open",
|
|
HTMLURL: "https://gitea.com/org/repo/issues/42",
|
|
Poster: &gitea_sdk.User{UserName: "alice"},
|
|
Labels: []*gitea_sdk.Label{{Name: "bug"}},
|
|
Milestone: &gitea_sdk.Milestone{
|
|
ID: 1,
|
|
Title: "v1.0",
|
|
},
|
|
PullRequest: &gitea_sdk.PullRequestMeta{HasMerged: false},
|
|
}
|
|
|
|
m := slimIssue(i)
|
|
|
|
if m["number"] != int64(42) {
|
|
t.Errorf("expected number 42, got %v", m["number"])
|
|
}
|
|
if m["body"] != "Something is broken" {
|
|
t.Errorf("expected body, got %v", m["body"])
|
|
}
|
|
if m["is_pull"] != true {
|
|
t.Error("expected is_pull true for issue with PullRequest")
|
|
}
|
|
|
|
ms := m["milestone"].(map[string]any)
|
|
if ms["title"] != "v1.0" {
|
|
t.Errorf("expected milestone title v1.0, got %v", ms["title"])
|
|
}
|
|
}
|
|
|
|
func TestBodyWithAttachments(t *testing.T) {
|
|
atts := []*gitea_sdk.Attachment{
|
|
{Name: "shot.png", DownloadURL: "https://example/shot.png"},
|
|
{Name: "log.txt", DownloadURL: "https://example/log.txt"},
|
|
}
|
|
got := bodyWithAttachments("see attached", atts)
|
|
want := "see attached\n\n[shot.png](https://example/shot.png)\n[log.txt](https://example/log.txt)"
|
|
if got != want {
|
|
t.Errorf("got %q, want %q", got, want)
|
|
}
|
|
|
|
if got := bodyWithAttachments("only body", nil); got != "only body" {
|
|
t.Errorf("nil attachments should return body unchanged, got %q", got)
|
|
}
|
|
if got := bodyWithAttachments("", atts); got != "[shot.png](https://example/shot.png)\n[log.txt](https://example/log.txt)" {
|
|
t.Errorf("empty body should drop separator, got %q", got)
|
|
}
|
|
skipped := []*gitea_sdk.Attachment{nil, {Name: "noop", DownloadURL: ""}}
|
|
if got := bodyWithAttachments("body", skipped); got != "body" {
|
|
t.Errorf("nil/empty-URL attachments should be skipped, got %q", got)
|
|
}
|
|
}
|
|
|
|
func TestSlimIssues_ListIsSlimmer(t *testing.T) {
|
|
i := &gitea_sdk.Issue{
|
|
Index: 1,
|
|
Title: "Issue",
|
|
State: "open",
|
|
Body: "Full body",
|
|
Poster: &gitea_sdk.User{UserName: "alice"},
|
|
Labels: []*gitea_sdk.Label{{Name: "enhancement"}},
|
|
}
|
|
|
|
single := slimIssue(i)
|
|
list := slimIssues([]*gitea_sdk.Issue{i})
|
|
|
|
// Single has body, list does not
|
|
if _, ok := single["body"]; !ok {
|
|
t.Error("single issue should have body")
|
|
}
|
|
if _, ok := list[0]["body"]; ok {
|
|
t.Error("list issue should not have body")
|
|
}
|
|
}
|
|
|
|
func TestSlimIssues_Nil(t *testing.T) {
|
|
if r := slimIssues(nil); len(r) != 0 {
|
|
t.Errorf("expected empty slice, got %v", r)
|
|
}
|
|
}
|