371a06403a
Net **-650 LOC** by removing duplication and dead noise. All tests pass.
### Duplication & helpers
- Extracted shared slim helpers (`UserLogin`, `UserLogins`, `LabelNames`, `BodyWithAttachments`, `UserDetail`, `Repo`/`Repos`, `Label`/`Labels`) into `pkg/slim`. Deleted the 4 copies that lived in `issue/`, `pull/`, `search/`, `repo/` (plus duplicate `slimUserDetail`/`slimRepo`/`slimLabels` across packages).
- Added `params.GetOptionalBoolPtr` and `params.GetOptionalStringPtr`. Replaced 18 awkward `new(localVar); if !ok { = nil }` patterns across `repo/`, `pull/`, `issue/`, `label/`, `milestone/`, `search/`.
- Extracted `pullRequestReviewerFn` for the 99%-identical `createPullRequestReviewerFn`/`deletePullRequestReviewerFn` pair.
### Dead code & noise
- Deleted **122** `log.Debugf("Called X")` narration lines (`zap.AddCaller` already records the caller) and pruned 19 unused `log` imports.
- Removed the unused `log.Logger` wrapper; the mcp-go server now uses `log.Default().Sugar()` directly (matches `util.Logger`).
- Deleted dead `s.DeleteTools("")` — confirmed no-op in mcp-go.
- Stripped WHAT-narration comments per project guidance.
### Correctness & consistency
- Fixed `log.Errorf(err.Error())` format-string bug in `pkg/to/to.go` — a `%` in the error would have been interpreted as a directive.
- Standardized `to.TextResult`/`to.ErrorResult` usage; `release.go`, `tag.go`, `branch.go` were bypassing the helpers in 9 sites (skipping the wrapper's debug/error logging).
- Made `params.GetString` reject empty strings; dropped 21 redundant `err != nil || x == ""` checks in `operation/actions/`.
- Replaced raw `args["org"].(string)` in `ListOrgReposFn` with `params.GetString` to match the rest of the codebase.
### Performance
- **Cached `*gitea.Client` by host+token via `sync.Map`** + shared `*http.Transport` via `sync.Once` for both SDK and raw REST paths. Eliminates the SDK's `/api/v1/version` preflight on every tool call and enables connection keep-alive across requests.
- Gated `to.TextResult` debug log behind `flag.Debug` to skip the `string(bytes)` allocation when debug is off.
- Hoisted `8192` and `60s` magic numbers in `pkg/gitea/rest.go` into named constants.
---
This PR was written with the help of Claude Opus 4.7
---------
Co-authored-by: silverwind <silv3rwind@gmail.com>
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/195
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
111 lines
2.9 KiB
Go
111 lines
2.9 KiB
Go
package slim
|
|
|
|
import (
|
|
"testing"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
)
|
|
|
|
func TestUserDetail(t *testing.T) {
|
|
u := &gitea_sdk.User{
|
|
ID: 42,
|
|
UserName: "alice",
|
|
FullName: "Alice Smith",
|
|
Email: "alice@example.com",
|
|
AvatarURL: "https://gitea.com/avatars/42",
|
|
HTMLURL: "https://gitea.com/alice",
|
|
IsAdmin: true,
|
|
}
|
|
m := UserDetail(u)
|
|
|
|
if m["id"] != int64(42) {
|
|
t.Errorf("expected id 42, got %v", m["id"])
|
|
}
|
|
if m["login"] != "alice" {
|
|
t.Errorf("expected login alice, got %v", m["login"])
|
|
}
|
|
if m["full_name"] != "Alice Smith" {
|
|
t.Errorf("expected full_name Alice Smith, got %v", m["full_name"])
|
|
}
|
|
if m["is_admin"] != true {
|
|
t.Errorf("expected is_admin true, got %v", m["is_admin"])
|
|
}
|
|
}
|
|
|
|
func TestUserDetail_Nil(t *testing.T) {
|
|
if m := UserDetail(nil); m != nil {
|
|
t.Errorf("expected nil for nil user, got %v", m)
|
|
}
|
|
}
|
|
|
|
func TestLabel(t *testing.T) {
|
|
l := &gitea_sdk.Label{
|
|
ID: 1,
|
|
Name: "bug",
|
|
Color: "#d73a4a",
|
|
Description: "Something isn't working",
|
|
Exclusive: false,
|
|
}
|
|
|
|
m := Label(l)
|
|
if m["name"] != "bug" {
|
|
t.Errorf("expected name bug, got %v", m["name"])
|
|
}
|
|
if m["color"] != "#d73a4a" {
|
|
t.Errorf("expected color, got %v", m["color"])
|
|
}
|
|
}
|
|
|
|
func TestRepo(t *testing.T) {
|
|
r := &gitea_sdk.Repository{
|
|
ID: 1,
|
|
FullName: "org/repo",
|
|
Description: "A test repo",
|
|
HTMLURL: "https://gitea.com/org/repo",
|
|
CloneURL: "https://gitea.com/org/repo.git",
|
|
SSHURL: "git@gitea.com:org/repo.git",
|
|
DefaultBranch: "main",
|
|
Language: "Go",
|
|
Stars: 10,
|
|
Forks: 2,
|
|
Owner: &gitea_sdk.User{UserName: "org"},
|
|
Topics: []string{"mcp", "gitea"},
|
|
}
|
|
|
|
m := Repo(r)
|
|
|
|
if m["full_name"] != "org/repo" {
|
|
t.Errorf("expected full_name org/repo, got %v", m["full_name"])
|
|
}
|
|
if m["owner"] != "org" {
|
|
t.Errorf("expected owner org, got %v", m["owner"])
|
|
}
|
|
topics := m["topics"].([]string)
|
|
if len(topics) != 2 {
|
|
t.Errorf("expected 2 topics, got %d", len(topics))
|
|
}
|
|
}
|
|
|
|
func TestBodyWithAttachments(t *testing.T) {
|
|
atts := []*gitea_sdk.Attachment{
|
|
{Name: "shot.png", DownloadURL: "https://example/shot.png"},
|
|
{Name: "log.txt", DownloadURL: "https://example/log.txt"},
|
|
}
|
|
got := BodyWithAttachments("see attached", atts)
|
|
want := "see attached\n\n[shot.png](https://example/shot.png)\n[log.txt](https://example/log.txt)"
|
|
if got != want {
|
|
t.Errorf("got %q, want %q", got, want)
|
|
}
|
|
|
|
if got := BodyWithAttachments("only body", nil); got != "only body" {
|
|
t.Errorf("nil attachments should return body unchanged, got %q", got)
|
|
}
|
|
if got := BodyWithAttachments("", atts); got != "[shot.png](https://example/shot.png)\n[log.txt](https://example/log.txt)" {
|
|
t.Errorf("empty body should drop separator, got %q", got)
|
|
}
|
|
skipped := []*gitea_sdk.Attachment{nil, {Name: "noop", DownloadURL: ""}}
|
|
if got := BodyWithAttachments("body", skipped); got != "body" {
|
|
t.Errorf("nil/empty-URL attachments should be skipped, got %q", got)
|
|
}
|
|
}
|