371a06403a
Net **-650 LOC** by removing duplication and dead noise. All tests pass.
### Duplication & helpers
- Extracted shared slim helpers (`UserLogin`, `UserLogins`, `LabelNames`, `BodyWithAttachments`, `UserDetail`, `Repo`/`Repos`, `Label`/`Labels`) into `pkg/slim`. Deleted the 4 copies that lived in `issue/`, `pull/`, `search/`, `repo/` (plus duplicate `slimUserDetail`/`slimRepo`/`slimLabels` across packages).
- Added `params.GetOptionalBoolPtr` and `params.GetOptionalStringPtr`. Replaced 18 awkward `new(localVar); if !ok { = nil }` patterns across `repo/`, `pull/`, `issue/`, `label/`, `milestone/`, `search/`.
- Extracted `pullRequestReviewerFn` for the 99%-identical `createPullRequestReviewerFn`/`deletePullRequestReviewerFn` pair.
### Dead code & noise
- Deleted **122** `log.Debugf("Called X")` narration lines (`zap.AddCaller` already records the caller) and pruned 19 unused `log` imports.
- Removed the unused `log.Logger` wrapper; the mcp-go server now uses `log.Default().Sugar()` directly (matches `util.Logger`).
- Deleted dead `s.DeleteTools("")` — confirmed no-op in mcp-go.
- Stripped WHAT-narration comments per project guidance.
### Correctness & consistency
- Fixed `log.Errorf(err.Error())` format-string bug in `pkg/to/to.go` — a `%` in the error would have been interpreted as a directive.
- Standardized `to.TextResult`/`to.ErrorResult` usage; `release.go`, `tag.go`, `branch.go` were bypassing the helpers in 9 sites (skipping the wrapper's debug/error logging).
- Made `params.GetString` reject empty strings; dropped 21 redundant `err != nil || x == ""` checks in `operation/actions/`.
- Replaced raw `args["org"].(string)` in `ListOrgReposFn` with `params.GetString` to match the rest of the codebase.
### Performance
- **Cached `*gitea.Client` by host+token via `sync.Map`** + shared `*http.Transport` via `sync.Once` for both SDK and raw REST paths. Eliminates the SDK's `/api/v1/version` preflight on every tool call and enables connection keep-alive across requests.
- Gated `to.TextResult` debug log behind `flag.Debug` to skip the `string(bytes)` allocation when debug is off.
- Hoisted `8192` and `60s` magic numbers in `pkg/gitea/rest.go` into named constants.
---
This PR was written with the help of Claude Opus 4.7
---------
Co-authored-by: silverwind <silv3rwind@gmail.com>
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/195
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
136 lines
2.7 KiB
Go
136 lines
2.7 KiB
Go
package slim
|
|
|
|
import (
|
|
"fmt"
|
|
"strings"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
)
|
|
|
|
func UserLogin(u *gitea_sdk.User) string {
|
|
if u == nil {
|
|
return ""
|
|
}
|
|
return u.UserName
|
|
}
|
|
|
|
func UserLogins(users []*gitea_sdk.User) []string {
|
|
if len(users) == 0 {
|
|
return nil
|
|
}
|
|
out := make([]string, 0, len(users))
|
|
for _, u := range users {
|
|
if u != nil {
|
|
out = append(out, u.UserName)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
|
|
func LabelNames(labels []*gitea_sdk.Label) []string {
|
|
if len(labels) == 0 {
|
|
return nil
|
|
}
|
|
out := make([]string, 0, len(labels))
|
|
for _, l := range labels {
|
|
if l != nil {
|
|
out = append(out, l.Name)
|
|
}
|
|
}
|
|
return out
|
|
}
|
|
|
|
func BodyWithAttachments(body string, atts []*gitea_sdk.Attachment) string {
|
|
links := make([]string, 0, len(atts))
|
|
for _, a := range atts {
|
|
if a == nil || a.DownloadURL == "" {
|
|
continue
|
|
}
|
|
links = append(links, fmt.Sprintf("[%s](%s)", a.Name, a.DownloadURL))
|
|
}
|
|
if len(links) == 0 {
|
|
return body
|
|
}
|
|
joined := strings.Join(links, "\n")
|
|
if body == "" {
|
|
return joined
|
|
}
|
|
return body + "\n\n" + joined
|
|
}
|
|
|
|
func UserDetail(u *gitea_sdk.User) map[string]any {
|
|
if u == nil {
|
|
return nil
|
|
}
|
|
return map[string]any{
|
|
"id": u.ID,
|
|
"login": u.UserName,
|
|
"full_name": u.FullName,
|
|
"email": u.Email,
|
|
"avatar_url": u.AvatarURL,
|
|
"html_url": u.HTMLURL,
|
|
"is_admin": u.IsAdmin,
|
|
}
|
|
}
|
|
|
|
func Repo(r *gitea_sdk.Repository) map[string]any {
|
|
if r == nil {
|
|
return nil
|
|
}
|
|
m := map[string]any{
|
|
"id": r.ID,
|
|
"full_name": r.FullName,
|
|
"description": r.Description,
|
|
"html_url": r.HTMLURL,
|
|
"clone_url": r.CloneURL,
|
|
"ssh_url": r.SSHURL,
|
|
"default_branch": r.DefaultBranch,
|
|
"private": r.Private,
|
|
"fork": r.Fork,
|
|
"archived": r.Archived,
|
|
"language": r.Language,
|
|
"stars_count": r.Stars,
|
|
"forks_count": r.Forks,
|
|
"open_issues_count": r.OpenIssues,
|
|
"open_pr_counter": r.OpenPulls,
|
|
"created_at": r.Created,
|
|
"updated_at": r.Updated,
|
|
}
|
|
if r.Owner != nil {
|
|
m["owner"] = r.Owner.UserName
|
|
}
|
|
if len(r.Topics) > 0 {
|
|
m["topics"] = r.Topics
|
|
}
|
|
return m
|
|
}
|
|
|
|
func Repos(repos []*gitea_sdk.Repository) []map[string]any {
|
|
out := make([]map[string]any, 0, len(repos))
|
|
for _, r := range repos {
|
|
out = append(out, Repo(r))
|
|
}
|
|
return out
|
|
}
|
|
|
|
func Label(l *gitea_sdk.Label) map[string]any {
|
|
if l == nil {
|
|
return nil
|
|
}
|
|
return map[string]any{
|
|
"id": l.ID,
|
|
"name": l.Name,
|
|
"color": l.Color,
|
|
"description": l.Description,
|
|
"exclusive": l.Exclusive,
|
|
}
|
|
}
|
|
|
|
func Labels(labels []*gitea_sdk.Label) []map[string]any {
|
|
out := make([]map[string]any, 0, len(labels))
|
|
for _, l := range labels {
|
|
out = append(out, Label(l))
|
|
}
|
|
return out
|
|
}
|