371a06403a
Net **-650 LOC** by removing duplication and dead noise. All tests pass.
### Duplication & helpers
- Extracted shared slim helpers (`UserLogin`, `UserLogins`, `LabelNames`, `BodyWithAttachments`, `UserDetail`, `Repo`/`Repos`, `Label`/`Labels`) into `pkg/slim`. Deleted the 4 copies that lived in `issue/`, `pull/`, `search/`, `repo/` (plus duplicate `slimUserDetail`/`slimRepo`/`slimLabels` across packages).
- Added `params.GetOptionalBoolPtr` and `params.GetOptionalStringPtr`. Replaced 18 awkward `new(localVar); if !ok { = nil }` patterns across `repo/`, `pull/`, `issue/`, `label/`, `milestone/`, `search/`.
- Extracted `pullRequestReviewerFn` for the 99%-identical `createPullRequestReviewerFn`/`deletePullRequestReviewerFn` pair.
### Dead code & noise
- Deleted **122** `log.Debugf("Called X")` narration lines (`zap.AddCaller` already records the caller) and pruned 19 unused `log` imports.
- Removed the unused `log.Logger` wrapper; the mcp-go server now uses `log.Default().Sugar()` directly (matches `util.Logger`).
- Deleted dead `s.DeleteTools("")` — confirmed no-op in mcp-go.
- Stripped WHAT-narration comments per project guidance.
### Correctness & consistency
- Fixed `log.Errorf(err.Error())` format-string bug in `pkg/to/to.go` — a `%` in the error would have been interpreted as a directive.
- Standardized `to.TextResult`/`to.ErrorResult` usage; `release.go`, `tag.go`, `branch.go` were bypassing the helpers in 9 sites (skipping the wrapper's debug/error logging).
- Made `params.GetString` reject empty strings; dropped 21 redundant `err != nil || x == ""` checks in `operation/actions/`.
- Replaced raw `args["org"].(string)` in `ListOrgReposFn` with `params.GetString` to match the rest of the codebase.
### Performance
- **Cached `*gitea.Client` by host+token via `sync.Map`** + shared `*http.Transport` via `sync.Once` for both SDK and raw REST paths. Eliminates the SDK's `/api/v1/version` preflight on every tool call and enables connection keep-alive across requests.
- Gated `to.TextResult` debug log behind `flag.Debug` to skip the `string(bytes)` allocation when debug is off.
- Hoisted `8192` and `60s` magic numbers in `pkg/gitea/rest.go` into named constants.
---
This PR was written with the help of Claude Opus 4.7
---------
Co-authored-by: silverwind <silv3rwind@gmail.com>
Reviewed-on: https://gitea.com/gitea/gitea-mcp/pulls/195
Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
Co-committed-by: silverwind <me@silverwind.io>
110 lines
2.6 KiB
Go
110 lines
2.6 KiB
Go
package repo
|
|
|
|
import (
|
|
"testing"
|
|
|
|
gitea_sdk "code.gitea.io/sdk/gitea"
|
|
)
|
|
|
|
func TestSlimTag(t *testing.T) {
|
|
tag := &gitea_sdk.Tag{
|
|
Name: "v1.0.0",
|
|
Message: "Release v1.0.0",
|
|
Commit: &gitea_sdk.CommitMeta{SHA: "abc123"},
|
|
}
|
|
|
|
m := slimTag(tag)
|
|
if m["name"] != "v1.0.0" {
|
|
t.Errorf("expected name v1.0.0, got %v", m["name"])
|
|
}
|
|
if m["message"] != "Release v1.0.0" {
|
|
t.Errorf("expected message, got %v", m["message"])
|
|
}
|
|
|
|
// List variant omits message
|
|
list := slimTags([]*gitea_sdk.Tag{tag})
|
|
if _, ok := list[0]["message"]; ok {
|
|
t.Error("Tags list should omit message")
|
|
}
|
|
if list[0]["name"] != "v1.0.0" {
|
|
t.Errorf("expected name in list, got %v", list[0]["name"])
|
|
}
|
|
}
|
|
|
|
func TestSlimRelease(t *testing.T) {
|
|
r := &gitea_sdk.Release{
|
|
ID: 1,
|
|
TagName: "v1.0.0",
|
|
Title: "First Release",
|
|
Note: "Release notes",
|
|
IsDraft: false,
|
|
Publisher: &gitea_sdk.User{UserName: "alice"},
|
|
}
|
|
|
|
m := slimRelease(r)
|
|
if m["tag_name"] != "v1.0.0" {
|
|
t.Errorf("expected tag_name v1.0.0, got %v", m["tag_name"])
|
|
}
|
|
if m["body"] != "Release notes" {
|
|
t.Errorf("expected body from Note field, got %v", m["body"])
|
|
}
|
|
if m["author"] != "alice" {
|
|
t.Errorf("expected author alice, got %v", m["author"])
|
|
}
|
|
}
|
|
|
|
func TestSlimContents(t *testing.T) {
|
|
content := "package main"
|
|
encoding := "base64"
|
|
htmlURL := "https://gitea.com/org/repo/src/branch/main/main.go"
|
|
c := &gitea_sdk.ContentsResponse{
|
|
Name: "main.go",
|
|
Path: "main.go",
|
|
SHA: "abc123",
|
|
Type: "file",
|
|
Size: 12,
|
|
Content: &content,
|
|
Encoding: &encoding,
|
|
HTMLURL: &htmlURL,
|
|
}
|
|
|
|
m := slimContents(c)
|
|
if m["name"] != "main.go" {
|
|
t.Errorf("expected name main.go, got %v", m["name"])
|
|
}
|
|
if m["content"] != "package main" {
|
|
t.Errorf("expected content, got %v", m["content"])
|
|
}
|
|
}
|
|
|
|
func TestSlimDirEntries(t *testing.T) {
|
|
entries := []*gitea_sdk.ContentsResponse{
|
|
{Name: "src", Path: "src", Type: "dir", Size: 0},
|
|
{Name: "main.go", Path: "main.go", Type: "file", Size: 100},
|
|
}
|
|
|
|
result := slimDirEntries(entries)
|
|
if len(result) != 2 {
|
|
t.Fatalf("expected 2 entries, got %d", len(result))
|
|
}
|
|
if result[0]["name"] != "src" {
|
|
t.Errorf("expected first entry name src, got %v", result[0]["name"])
|
|
}
|
|
// Dir entries should not have content
|
|
if _, ok := result[0]["content"]; ok {
|
|
t.Error("dir entries should not have content field")
|
|
}
|
|
}
|
|
|
|
func TestSlimTags_Nil(t *testing.T) {
|
|
if r := slimTags(nil); len(r) != 0 {
|
|
t.Errorf("expected empty slice, got %v", r)
|
|
}
|
|
}
|
|
|
|
func TestSlimReleases_Nil(t *testing.T) {
|
|
if r := slimReleases(nil); len(r) != 0 {
|
|
t.Errorf("expected empty slice, got %v", r)
|
|
}
|
|
}
|